Multi-pin pickup selection (study §3.4) — previously a standalone unused
endpoint + TODO comments:
- app/services/pickup-locations.server.ts: pure filterPickupLocationIds +
I/O resolvePickupLocations (active + has a PICKUP slot template +
ProductRule allowedLocationIds + inventory exclusion).
- resolveAvailabilityRequest returns pickupLocations[] on method=PICKUP and
defaults the active location to the first eligible pickup point.
- apps.scheduling.locations.tsx refactored onto the shared resolver
(was a second copy of the logic).
- Storefront widget: pickup-location chooser (name + address, optional
multi-pin Google map) when >1 eligible point and none block-configured;
picking one re-requests availability for that location. New styles +
widget.choose_pickup_location locale (en + fr).
- Checkout extension Checkout.jsx: same chooser before the date list.
- tests/unit/pickup-locations.test.ts (5 cases); suite 161 green.
checkout-datetime follow-up fixes from the 808a3b7 review:
- typescript devDep ^7.0.2 -> ^5.6.3 (there is no typescript@7 on npm).
- Deleted dead shopify.d.ts (Preact-global shim, unused after the React
rewrite) and dropped it from tsconfig include.
Also stages the CLI-written `uid` lines in the checkout-datetime and
payment-customization extension tomls.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Audited the implementation against DS_Delivery_Date_Time_App_Study.docx and
closed the actionable gaps (see IMPLEMENTATION_REVIEW_2026-09-04.md).
Core (code + unit tests, 156 green):
- Wire excludeLocationsWithoutStock into resolveAvailabilityRequest; widget
now sends variantIds so inventory-based location exclusion actually runs.
- Live slot re-validation at checkout: new checkout-snapshot.server.ts writes
a shop-metafield capacity snapshot; validation-slot's evaluateCheckout
rejects a complete selection that has since filled / blacked out / closed /
hit the daily cap / left the schedule. Refreshed on order webhooks and
slot/blackout/location/enforcement edits.
- Scopable checkout enforcement: Shop.enforcementMode (all|tagged|off) +
enforcementTag, new app.settings.tsx admin page, honoured via the snapshot.
- Per-day order cap: Location.dailyOrderCap threaded through getAvailability
(dailyCap + consumedPerDate); admin field on the location screen.
- Product-rule slot blocking: ProductRule.blockedStartMins, unioned in
resolveProductRuleConstraints, enforced in the engine and resolveHoldRequest;
admin field on the product rules screen.
- Product-page placement: product-availability.liquid block + widget
data-mode="preview" (read-only earliest-date line).
- Second locale: datetime-widget fr.json / fr.schema.json.
- Migration 20260904120000_review_gaps (apply with prisma migrate deploy).
New Functions (source + unit tests; need `shopify app deploy` to ship):
- extensions/payment-customization: cart.payment-methods.transform.run — hides
cash-on-delivery / pay-in-store gateways on SHIPPING orders.
- extensions/checkout-datetime/src: restored from a gitignored dist-only state
— Plus native picker + Thank you / Order status confirmation blocks, all
calling the existing checkout.scheduling.* routes (one capacity pool).
tsconfig ships checkJs:false pending reconciliation with live checkout types.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
