a2c78d703f
Some checks failed
CI / Lint, Unit & Integration Tests (push) Has been cancelled
Audited the implementation against DS_Delivery_Date_Time_App_Study.docx and closed the actionable gaps (see IMPLEMENTATION_REVIEW_2026-09-04.md). Core (code + unit tests, 156 green): - Wire excludeLocationsWithoutStock into resolveAvailabilityRequest; widget now sends variantIds so inventory-based location exclusion actually runs. - Live slot re-validation at checkout: new checkout-snapshot.server.ts writes a shop-metafield capacity snapshot; validation-slot's evaluateCheckout rejects a complete selection that has since filled / blacked out / closed / hit the daily cap / left the schedule. Refreshed on order webhooks and slot/blackout/location/enforcement edits. - Scopable checkout enforcement: Shop.enforcementMode (all|tagged|off) + enforcementTag, new app.settings.tsx admin page, honoured via the snapshot. - Per-day order cap: Location.dailyOrderCap threaded through getAvailability (dailyCap + consumedPerDate); admin field on the location screen. - Product-rule slot blocking: ProductRule.blockedStartMins, unioned in resolveProductRuleConstraints, enforced in the engine and resolveHoldRequest; admin field on the product rules screen. - Product-page placement: product-availability.liquid block + widget data-mode="preview" (read-only earliest-date line). - Second locale: datetime-widget fr.json / fr.schema.json. - Migration 20260904120000_review_gaps (apply with prisma migrate deploy). New Functions (source + unit tests; need `shopify app deploy` to ship): - extensions/payment-customization: cart.payment-methods.transform.run — hides cash-on-delivery / pay-in-store gateways on SHIPPING orders. - extensions/checkout-datetime/src: restored from a gitignored dist-only state — Plus native picker + Thank you / Order status confirmation blocks, all calling the existing checkout.scheduling.* routes (one capacity pool). tsconfig ships checkJs:false pending reconciliation with live checkout types. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
42 lines
1.6 KiB
TypeScript
42 lines
1.6 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { paymentMethodNamesToHide, DEFAULT_HIDE_PATTERN } from "../../extensions/payment-customization/src/evaluate.js";
|
|
|
|
const METHODS = ["Credit card", "Shop Pay", "Cash on Delivery (COD)", "Pay in store"];
|
|
|
|
describe("paymentMethodNamesToHide", () => {
|
|
it("hides pay-in-person methods on a shipped order", () => {
|
|
const hidden = paymentMethodNamesToHide({ dd_method: "SHIPPING" }, METHODS);
|
|
expect(hidden.sort()).toEqual(["Cash on Delivery (COD)", "Pay in store"]);
|
|
});
|
|
|
|
it("hides nothing for a pickup order", () => {
|
|
expect(paymentMethodNamesToHide({ dd_method: "PICKUP" }, METHODS)).toEqual([]);
|
|
});
|
|
|
|
it("hides nothing for a local delivery order", () => {
|
|
expect(paymentMethodNamesToHide({ dd_method: "LOCAL_DELIVERY" }, METHODS)).toEqual([]);
|
|
});
|
|
|
|
it("hides nothing when no fulfillment method has been chosen yet", () => {
|
|
expect(paymentMethodNamesToHide({}, METHODS)).toEqual([]);
|
|
});
|
|
|
|
it("leaves ordinary gateways alone even when shipping", () => {
|
|
const hidden = paymentMethodNamesToHide({ dd_method: "SHIPPING" }, ["Credit card", "Shop Pay", "PayPal"]);
|
|
expect(hidden).toEqual([]);
|
|
});
|
|
|
|
it("accepts a custom pattern", () => {
|
|
const hidden = paymentMethodNamesToHide({ dd_method: "SHIPPING" }, ["Bank transfer", "Credit card"], {
|
|
pattern: /bank transfer/i,
|
|
});
|
|
expect(hidden).toEqual(["Bank transfer"]);
|
|
});
|
|
|
|
it("matches common COD spellings", () => {
|
|
for (const name of ["Cash on delivery", "COD", "C.O.D.", "Pay on delivery", "Pay on pickup", "Pay in person"]) {
|
|
expect(DEFAULT_HIDE_PATTERN.test(name)).toBe(true);
|
|
}
|
|
});
|
|
});
|