a2c78d703f
Some checks failed
CI / Lint, Unit & Integration Tests (push) Has been cancelled
Audited the implementation against DS_Delivery_Date_Time_App_Study.docx and closed the actionable gaps (see IMPLEMENTATION_REVIEW_2026-09-04.md). Core (code + unit tests, 156 green): - Wire excludeLocationsWithoutStock into resolveAvailabilityRequest; widget now sends variantIds so inventory-based location exclusion actually runs. - Live slot re-validation at checkout: new checkout-snapshot.server.ts writes a shop-metafield capacity snapshot; validation-slot's evaluateCheckout rejects a complete selection that has since filled / blacked out / closed / hit the daily cap / left the schedule. Refreshed on order webhooks and slot/blackout/location/enforcement edits. - Scopable checkout enforcement: Shop.enforcementMode (all|tagged|off) + enforcementTag, new app.settings.tsx admin page, honoured via the snapshot. - Per-day order cap: Location.dailyOrderCap threaded through getAvailability (dailyCap + consumedPerDate); admin field on the location screen. - Product-rule slot blocking: ProductRule.blockedStartMins, unioned in resolveProductRuleConstraints, enforced in the engine and resolveHoldRequest; admin field on the product rules screen. - Product-page placement: product-availability.liquid block + widget data-mode="preview" (read-only earliest-date line). - Second locale: datetime-widget fr.json / fr.schema.json. - Migration 20260904120000_review_gaps (apply with prisma migrate deploy). New Functions (source + unit tests; need `shopify app deploy` to ship): - extensions/payment-customization: cart.payment-methods.transform.run — hides cash-on-delivery / pay-in-store gateways on SHIPPING orders. - extensions/checkout-datetime/src: restored from a gitignored dist-only state — Plus native picker + Thank you / Order status confirmation blocks, all calling the existing checkout.scheduling.* routes (one capacity pool). tsconfig ships checkJs:false pending reconciliation with live checkout types. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
31 lines
1.5 KiB
JavaScript
31 lines
1.5 KiB
JavaScript
// @ts-check
|
|
// Pure decision logic, kept separate from the run.js adapter so it's
|
|
// unit-testable directly with plain Vitest (see
|
|
// tests/unit/payment-customization.test.ts at the repo root) with no WASM
|
|
// build.
|
|
//
|
|
// Study §5.2 / DS parity: "payment options can be adjusted based on the
|
|
// fulfillment method chosen — e.g. hiding cash-on-delivery for a shipped
|
|
// order." A shipped order leaves the store before it's paid in person, so
|
|
// cash-on-delivery / pay-in-store gateways make no sense for it; pickup and
|
|
// local delivery keep every method.
|
|
|
|
/** Matches the common names Shopify merchants give manual "pay later / in person" gateways. */
|
|
export const DEFAULT_HIDE_PATTERN = /cash on delivery|\bc\.?o\.?d\.?\b|pay on delivery|pay on pickup|pay in store|pay in person/i;
|
|
|
|
/**
|
|
* @param {Record<string, string | null | undefined>} attributes The cart's dd_* attributes.
|
|
* @param {string[]} paymentMethodNames Names of every payment method offered at checkout.
|
|
* @param {{ pattern?: RegExp }} [options]
|
|
* @returns {string[]} the subset of `paymentMethodNames` that should be hidden.
|
|
*/
|
|
export function paymentMethodNamesToHide(attributes, paymentMethodNames, options = {}) {
|
|
const pattern = options.pattern ?? DEFAULT_HIDE_PATTERN;
|
|
|
|
// Only shipped orders lose the pay-in-person options. No selection yet, or
|
|
// pickup/local delivery → touch nothing.
|
|
if (attributes.dd_method !== "SHIPPING") return [];
|
|
|
|
return paymentMethodNames.filter((name) => typeof name === "string" && pattern.test(name));
|
|
}
|