a2c78d703f
Some checks failed
CI / Lint, Unit & Integration Tests (push) Has been cancelled
Audited the implementation against DS_Delivery_Date_Time_App_Study.docx and closed the actionable gaps (see IMPLEMENTATION_REVIEW_2026-09-04.md). Core (code + unit tests, 156 green): - Wire excludeLocationsWithoutStock into resolveAvailabilityRequest; widget now sends variantIds so inventory-based location exclusion actually runs. - Live slot re-validation at checkout: new checkout-snapshot.server.ts writes a shop-metafield capacity snapshot; validation-slot's evaluateCheckout rejects a complete selection that has since filled / blacked out / closed / hit the daily cap / left the schedule. Refreshed on order webhooks and slot/blackout/location/enforcement edits. - Scopable checkout enforcement: Shop.enforcementMode (all|tagged|off) + enforcementTag, new app.settings.tsx admin page, honoured via the snapshot. - Per-day order cap: Location.dailyOrderCap threaded through getAvailability (dailyCap + consumedPerDate); admin field on the location screen. - Product-rule slot blocking: ProductRule.blockedStartMins, unioned in resolveProductRuleConstraints, enforced in the engine and resolveHoldRequest; admin field on the product rules screen. - Product-page placement: product-availability.liquid block + widget data-mode="preview" (read-only earliest-date line). - Second locale: datetime-widget fr.json / fr.schema.json. - Migration 20260904120000_review_gaps (apply with prisma migrate deploy). New Functions (source + unit tests; need `shopify app deploy` to ship): - extensions/payment-customization: cart.payment-methods.transform.run — hides cash-on-delivery / pay-in-store gateways on SHIPPING orders. - extensions/checkout-datetime/src: restored from a gitignored dist-only state — Plus native picker + Thank you / Order status confirmation blocks, all calling the existing checkout.scheduling.* routes (one capacity pool). tsconfig ships checkJs:false pending reconciliation with live checkout types. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
59 lines
3.0 KiB
TypeScript
59 lines
3.0 KiB
TypeScript
import type { LoaderFunctionArgs } from "@remix-run/node";
|
|
import type { Method } from "@prisma/client";
|
|
import { authenticate } from "../shopify.server";
|
|
import { resolveAvailabilityRequest } from "../services/availability-request.server";
|
|
import { resolveProductRefs } from "../services/product-rules.server";
|
|
import { parseCartLinesParam, parseProductIdsParam, parseGidListParam } from "../lib/cart-rule-params";
|
|
|
|
// Public endpoint, reachable only through Shopify's App Proxy (signature
|
|
// verified by authenticate.public.appProxy) — this is what the storefront
|
|
// Theme App Extension calls. Requests to https://{shop}/apps/scheduling/*
|
|
// forward here because shopify.app.toml's [app_proxy].url already includes
|
|
// the /apps/scheduling prefix, so this file's path (apps.scheduling.*)
|
|
// mirrors the shop-facing URL exactly. The actual resolution logic lives in
|
|
// services/availability-request.server.ts, shared with the POS route
|
|
// (pos.scheduling.availability.tsx) — same pool, same code, different auth.
|
|
|
|
const VALID_METHODS = new Set<Method>(["SHIPPING", "LOCAL_DELIVERY", "PICKUP"]);
|
|
|
|
export const loader = async ({ request }: LoaderFunctionArgs) => {
|
|
const { session, admin } = await authenticate.public.appProxy(request);
|
|
if (!session) {
|
|
return Response.json({ error: "Shop not found" }, { status: 404 });
|
|
}
|
|
|
|
const url = new URL(request.url);
|
|
const methodParam = url.searchParams.get("method");
|
|
if (!methodParam || !VALID_METHODS.has(methodParam as Method)) {
|
|
return Response.json({ error: "Invalid or missing method" }, { status: 400 });
|
|
}
|
|
|
|
// ProductRule scoping (PRODUCT_STRATEGY.md §2): vendor/type come free from
|
|
// the widget's own /cart.js read; product/collection/tag rules additionally
|
|
// need one Admin API round trip to resolve productIds — skipped gracefully
|
|
// if there's no admin client (shouldn't happen for an installed shop's app
|
|
// proxy request, but this endpoint must not 500 over an optional feature).
|
|
const productIds = parseProductIdsParam(url.searchParams.get("productIds"));
|
|
const productRefs = admin && productIds.length > 0 ? await resolveProductRefs(admin, productIds) : [];
|
|
|
|
const result = await resolveAvailabilityRequest(session.shop, {
|
|
method: methodParam as Method,
|
|
locationId: url.searchParams.get("locationId") || undefined,
|
|
postalCode: url.searchParams.get("postalCode") || undefined,
|
|
address: url.searchParams.get("address") || undefined,
|
|
days: Number(url.searchParams.get("days")) || undefined,
|
|
cartLines: parseCartLinesParam(url.searchParams.get("cartLines")),
|
|
productRefs,
|
|
// Inventory-based location exclusion (study §3.4) — only the app-proxy
|
|
// surface has an Admin client, so it's the only one that can run it.
|
|
productVariantGids: parseGidListParam(url.searchParams.get("variantIds")),
|
|
admin: admin ?? undefined,
|
|
});
|
|
|
|
if (!result.locationId) {
|
|
return Response.json(result, { status: result.error === "No active location configured" ? 404 : 200 });
|
|
}
|
|
|
|
return Response.json(result);
|
|
};
|