b94ee06d3a
Reported: clicking "Post a Listing" on /classifieds while logged out threw a raw 500 instead of prompting login. Root cause is upstream, in this Odoo 19 build's own http.py: when auth='user' raises SessionExpiredException for an anonymous visitor, Request._serve_db's `finally: self.env = None` clears the request env before the exception reaches the website error handler, which then tries to build the login redirect via self.env['ir.http']._redirect(...) and crashes with TypeError: 'NoneType' object is not subscriptable. This isn't specific to any one route - it reproduces on every auth='user' + website=True page hit anonymously, including stock Odoo's own /my (traced this back to the true cause rather than continuing to treat it as an unrelated environment quirk, since it now has a real reported symptom). Since core can't be patched here, worked around it at the route level across all 9 affected pages (classifieds new/my/renew, membership my/renew/card, benefits my, school attendance, portal my/school, event checkin): switched from auth='user' to auth='public' and added an explicit `if request.env.user._is_public(): return request.redirect(...)` check at the top of each handler, before Odoo's own auth layer ever gets a chance to raise. The jsonrpc AJAX endpoints (attendance save, checkin scan/dashboard) were left on auth='user' since they return a JSON error rather than attempting an HTML redirect, so they don't hit this path. Verified against a live Odoo 19 + Postgres 16 container: reproduced the original crash pre-fix, then confirmed all 9 previously-broken routes now 303-redirect to /web/login?redirect=<path> when hit anonymously, that the login page carries the redirect target, that logged-in access is unaffected (200), and that the separate "logged in but lacking a required group" case (event check-in without Registration Desk) still degrades gracefully to a clean 403 rather than a crash. Full regression: 48/48 tests pass across the six touched modules. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
60 lines
2.5 KiB
Python
60 lines
2.5 KiB
Python
from odoo import http
|
|
from odoo.addons.portal.controllers.portal import CustomerPortal
|
|
from odoo.http import request
|
|
|
|
SOFT_DETECTED_MODULES = (
|
|
'community_membership',
|
|
'event_qr_ticketing',
|
|
'community_school',
|
|
'community_benefits',
|
|
'community_classifieds',
|
|
)
|
|
|
|
|
|
class CommunityPortalDashboard(CustomerPortal):
|
|
|
|
def _get_installed_community_modules(self):
|
|
"""Soft-detect which Community OS product modules are installed."""
|
|
installed = request.env['ir.module.module'].sudo().search([
|
|
('name', 'in', list(SOFT_DETECTED_MODULES)),
|
|
('state', '=', 'installed'),
|
|
])
|
|
return set(installed.mapped('name'))
|
|
|
|
def _prepare_home_portal_values(self, counters):
|
|
values = super()._prepare_home_portal_values(counters)
|
|
partner = request.env.user.partner_id
|
|
installed = self._get_installed_community_modules()
|
|
|
|
if 'event_registration_count' in counters and 'event_qr_ticketing' in installed:
|
|
values['event_registration_count'] = request.env['event.registration'].sudo().search_count([
|
|
('partner_id', '=', partner.id),
|
|
])
|
|
|
|
if 'school_enrollment_count' in counters and 'community_school' in installed:
|
|
values['school_enrollment_count'] = request.env['community.school.student'].sudo().search_count([
|
|
('parent_partner_id', '=', partner.id),
|
|
])
|
|
|
|
if 'benefits_count' in counters and 'community_benefits' in installed:
|
|
Benefit = request.env['community.benefit'].sudo()
|
|
entitled = Benefit.search(Benefit._entitled_domain_for_partner(partner))
|
|
values['benefits_count'] = len(entitled.filtered(lambda b: b.is_entitled(partner)))
|
|
|
|
if 'classifieds_count' in counters and 'community_classifieds' in installed:
|
|
values['classifieds_count'] = request.env['community.classified'].sudo().search_count([
|
|
('poster_partner_id', '=', partner.id),
|
|
])
|
|
|
|
return values
|
|
|
|
@http.route(['/my/school'], type='http', auth='public', website=True)
|
|
def portal_my_school(self, **kwargs):
|
|
if request.env.user._is_public():
|
|
return request.redirect('/web/login?redirect=/my/school')
|
|
partner = request.env.user.partner_id
|
|
students = request.env['community.school.student'].sudo().search([
|
|
('parent_partner_id', '=', partner.id),
|
|
])
|
|
return request.render('community_portal.portal_my_school', {'students': students})
|