709bd2eca7
Rounds out mc_education_base with the remaining O1 models: mc.program,
mc.subject, mc.room, mc.batch, mc.teacher, mc.student, mc.guardian,
mc.student.guardian, and mc.enrollment - the spine everything else in
the O1 table (attendance, timetable, exam, portal) is built against.
Two rules get the same "DB constraint is the real guarantee, the ORM
does a friendly pre-check" treatment as academic.year.is_current:
- At most one primary guardian per student (mc.student.guardian):
partial unique index on student_id WHERE is_primary, plus a
create/write toggle.
- At most one Active enrollment per student per year
(mc.enrollment): partial unique index on (student_id, year_id)
WHERE state='active'. This one is CLAUDE.md's flagship rule
("Enforce as a database constraint, not application logic").
Two more real bugs surfaced by testing against a live odoo:19.0
container rather than trusting the code by inspection:
- The partial unique index fires at INSERT/UPDATE time, before
@api.constrains ever runs - so a naive "index + constrains for a
friendly message" design never reaches the friendly message, the
raw IntegrityError wins the race. Fixed by pre-checking for a
conflict in create()/write() before calling super(), with
@api.constrains kept only as a backstop for batch creates.
- create() issues a direct SQL INSERT that does not wait for
unrelated pending writes in the ORM cache (e.g. withdrawing one
enrollment right before creating its replacement, in the same
method) - needs an explicit self.env.flush_all() first, same
lesson as the is_current toggle.
Also caught before it became a permanent test flake: the enrollment
and academic-calendar tests originally hardcoded the same year names
("2025-26", "2026-27") and program code ("G8") as the demo data.
Passed in isolation, failed as soon as demo data was loaded first -
so verification here included a combined
`--without-demo=False --test-enable` run, matching what CI actually
does, not just an isolated test-tagged run. Renamed to TEST-prefixed
fixtures.
Security access rows added for all new models across the four
internal groups (Administrator: full CRUD everywhere; Staff: full
CRUD on the people/enrollment models that are front office's daily
job, read-only on academic structure; Teacher/Accountant: read-only
across the board, narrower record rules land with the modules that
need them - attendance, exam, portal). No portal-group access yet;
that is O7's job once explicit ownership-scoped record rules exist -
granting it now without those rules would be exactly the "identifier
supplied by the client" hole CLAUDE.md's standing security rule
warns about.
Demo data populates the shared/DEMO_SCRIPT.md cast: Meera Krishnan as
primary guardian of both Aditya (Grade 8-A) and Ananya (Grade 5-B) -
the multi-child guardian view the script calls "the single most
convincing portal feature" - plus Arun Prakash as Grade 8-A's class
teacher. Verified by querying the resulting database directly, not
just by the install succeeding.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
73 lines
2.9 KiB
Python
73 lines
2.9 KiB
Python
from psycopg2 import IntegrityError
|
|
|
|
from odoo.tests.common import TransactionCase
|
|
from odoo.tools import mute_logger
|
|
|
|
|
|
class TestPeople(TransactionCase):
|
|
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
super().setUpClass()
|
|
cls.student_partner = cls.env["res.partner"].create({"name": "Test Student"})
|
|
cls.student = cls.env["mc.student"].create({
|
|
"partner_id": cls.student_partner.id, "name": "Test Student",
|
|
})
|
|
cls.guardian_a_partner = cls.env["res.partner"].create({"name": "Guardian A"})
|
|
cls.guardian_a = cls.env["mc.guardian"].create({
|
|
"partner_id": cls.guardian_a_partner.id, "name": "Guardian A",
|
|
})
|
|
cls.guardian_b_partner = cls.env["res.partner"].create({"name": "Guardian B"})
|
|
cls.guardian_b = cls.env["mc.guardian"].create({
|
|
"partner_id": cls.guardian_b_partner.id, "name": "Guardian B",
|
|
})
|
|
|
|
def test_setting_primary_on_create_unsets_previous(self):
|
|
Link = self.env["mc.student.guardian"]
|
|
link_a = Link.create({
|
|
"student_id": self.student.id, "guardian_id": self.guardian_a.id,
|
|
"relationship": "mother", "is_primary": True,
|
|
})
|
|
link_b = Link.create({
|
|
"student_id": self.student.id, "guardian_id": self.guardian_b.id,
|
|
"relationship": "father", "is_primary": True,
|
|
})
|
|
self.assertFalse(link_a.is_primary, "A second primary guardian must unset the first.")
|
|
self.assertTrue(link_b.is_primary)
|
|
|
|
def test_setting_primary_on_write_unsets_previous(self):
|
|
Link = self.env["mc.student.guardian"]
|
|
link_a = Link.create({
|
|
"student_id": self.student.id, "guardian_id": self.guardian_a.id,
|
|
"relationship": "mother", "is_primary": True,
|
|
})
|
|
link_b = Link.create({
|
|
"student_id": self.student.id, "guardian_id": self.guardian_b.id,
|
|
"relationship": "father", "is_primary": False,
|
|
})
|
|
link_b.write({"is_primary": True})
|
|
self.assertFalse(link_a.is_primary)
|
|
self.assertTrue(link_b.is_primary)
|
|
|
|
@mute_logger("odoo.sql_db")
|
|
def test_duplicate_student_guardian_link_rejected(self):
|
|
Link = self.env["mc.student.guardian"]
|
|
Link.create({
|
|
"student_id": self.student.id, "guardian_id": self.guardian_a.id,
|
|
"relationship": "mother",
|
|
})
|
|
with self.assertRaises(IntegrityError):
|
|
with self.cr.savepoint():
|
|
Link.create({
|
|
"student_id": self.student.id, "guardian_id": self.guardian_a.id,
|
|
"relationship": "father",
|
|
})
|
|
|
|
@mute_logger("odoo.sql_db")
|
|
def test_partner_cannot_back_two_student_records(self):
|
|
with self.assertRaises(IntegrityError):
|
|
with self.cr.savepoint():
|
|
self.env["mc.student"].create({
|
|
"partner_id": self.student_partner.id, "name": "Duplicate",
|
|
})
|