From 59d1dd24cb670596c7c60cc5ce5234d99fcddb64 Mon Sep 17 00:00:00 2001
From: Ben Senescu <44480372+bensenescu@users.noreply.github.com>
Date: Thu, 16 Apr 2026 12:23:52 -0400
Subject: [PATCH] fix: use VALIDATION_ERROR for rank tracking config validation
 errors (#119)

INTERNAL_ERROR was showing "An unexpected error occurred" to users and
triggering PostHog error monitoring for expected validation cases
(duplicate domain+country, max configs reached).
---
 .../features/rank-tracking/services/RankTrackingService.ts    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/server/features/rank-tracking/services/RankTrackingService.ts b/src/server/features/rank-tracking/services/RankTrackingService.ts
index 5f47533..7c05b9a 100644
--- a/src/server/features/rank-tracking/services/RankTrackingService.ts
+++ b/src/server/features/rank-tracking/services/RankTrackingService.ts
@@ -43,7 +43,7 @@ async function createConfig(input: {
     );
   if (existing) {
     throw new AppError(
-      "INTERNAL_ERROR",
+      "VALIDATION_ERROR",
       "This domain + country combination is already being tracked",
     );
   }
@@ -53,7 +53,7 @@ async function createConfig(input: {
   );
   if (allConfigs.length >= MAX_CONFIGS_PER_PROJECT) {
     throw new AppError(
-      "INTERNAL_ERROR",
+      "VALIDATION_ERROR",
       `Maximum ${MAX_CONFIGS_PER_PROJECT} tracked domains per project`,
     );
   }